This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode

From: Jeff Law <law at redhat dot com>
To: Senthil Kumar Selvaraj <senthil_kumar dot selvaraj at atmel dot com>, Richard Biener <rguenther at suse dot de>
Cc: gcc-patches at gcc dot gnu dot org
Date: Thu, 19 Nov 2015 10:31:41 -0700
Subject: Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode
Authentication-results: sourceware.org; auth=none
References: <20151114071148 dot GA16647 at jaguar dot atmel dot com> <alpine dot DEB dot 2 dot 20 dot 1511140907420 dot 1923 at laptop-mg dot saclay dot inria dot fr> <20151114084928 dot GA749 at jaguar dot atmel dot com> <595F0CF8-27C1-4A63-8339-F70CB5E76CAB at suse dot de> <20151114181044 dot GA1297 at jaguar dot atmel dot com> <alpine dot LSU dot 2 dot 11 dot 1511160956220 dot 4884 at t29 dot fhfr dot qr> <20151117195241 dot GA5579 at jaguar dot atmel dot com> <alpine dot LSU dot 2 dot 11 dot 1511180934030 dot 4884 at t29 dot fhfr dot qr> <20151119062014 dot GA2345 at jaguar dot corp dot atmel dot com>

On 11/18/2015 11:20 PM, Senthil Kumar Selvaraj wrote:

On Wed, Nov 18, 2015 at 09:36:21AM +0100, Richard Biener wrote:


Otherwise ok.


See modified patch below. If you think vrp98.c is unnecessary, feel free
to dump it :).

If ok, could you commit it for me please? I don't have commit access.

Regards
Senthil

gcc/ChangeLog
2015-11-19  Senthil Kumar Selvaraj  <senthil_kumar.selvaraj@atmel.com>

	* tree.h (desired_pro_or_demotion_p): New function.
	* tree-vrp.c (simplify_cond_using_ranges): Call it.

gcc/testsuite/ChangeLog
2015-11-19  Senthil Kumar Selvaraj  <senthil_kumar.selvaraj@atmel.com>

	* gcc.dg/tree-ssa/vrp98.c: New testcase.
	* gcc.target/avr/uint8-single-reg.c: New testcase.

I went ahead and committed this as-is.

I do think the vrp98 testcase is useful as it verifies that VRP is doingwhat we want in a target independent way. It's a good complement to theAVR specific testcase.


Thanks,
Jeff

Follow-Ups:
- Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode
  - From: Senthil Kumar Selvaraj

References:
- [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode
  - From: Senthil Kumar Selvaraj
- Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode
  - From: Marc Glisse
- Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode
  - From: Senthil Kumar Selvaraj
- Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode
  - From: Richard Biener
- Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode
  - From: Senthil Kumar Selvaraj
- Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode
  - From: Richard Biener
- Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode
  - From: Senthil Kumar Selvaraj
- Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode
  - From: Richard Biener
- Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode
  - From: Senthil Kumar Selvaraj

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]