This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: nvptx priority queues nonsupport in libgomp
- From: Cesar Philippidis <cesar at codesourcery dot com>
- To: Nathan Sidwell <nathan_sidwell at mentor dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jakub Jelinek <jakub at redhat dot com>, Thomas Schwinge <thomas at codesourcery dot com>
- Date: Tue, 17 Nov 2015 09:30:14 -0800
- Subject: Re: nvptx priority queues nonsupport in libgomp
- Authentication-results: sourceware.org; auth=none
- References: <564B60D5 dot 8070101 at codesourcery dot com> <564B6280 dot 4060807 at codesourcery dot com> <564B62A7 dot 3070001 at mentor dot com>
On 11/17/2015 09:23 AM, Nathan Sidwell wrote:
> On 11/17/15 12:23, Nathan Sidwell wrote:
>> On 11/17/15 12:16, Cesar Philippidis wrote:
>>> This patch adds an empty priority_queues.c in libgomp for nvptx targets.
>>> Nvptx targets don't have sufficient support for a complete libgomp
>>> library, so we're only building a subset of it. And without that empty
>>> file, I was seeing an error message that looked like this:
>>>
>>> libgomp/libgomp.h:122:17: fatal error: sem.h: No such file or directory
>>> #include "sem.h"
>>>
>>> I'm still running the entire testsuite, but it doesn't introduce any new
>>> regressions in libgomp.oacc-c. Is this OK for trunk, or am I missing
>>> something?
>>
>> Please apply to trunk. I've just tripped over it, you've saved me an
>> investigation ...
>
> Actually, please put a comment in the file, rather than leave it empty
OK. I've applied this patch in r230466.
Cesar
2015-11-17 Cesar Philippidis <cesar@codesourcery.com>
libgomp/
* config/nvptx/priority_queue.c: New file.
diff --git a/libgomp/config/nvptx/priority_queue.c b/libgomp/config/nvptx/priority_queue.c
new file mode 100644
index 0000000..63aecd2
--- /dev/null
+++ b/libgomp/config/nvptx/priority_queue.c
@@ -0,0 +1 @@
+/* Empty stub for omp task priority support. */