This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][i386]Migrate reduction optabs to reduc_<op>_scal
- From: Kirill Yukhin <kirill dot yukhin at gmail dot com>
- To: Alan Lawrence <alan dot lawrence at arm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Uros Bizjak <ubizjak at gmail dot com>
- Date: Mon, 16 Nov 2015 16:07:07 +0300
- Subject: Re: [PATCH][i386]Migrate reduction optabs to reduc_<op>_scal
- Authentication-results: sourceware.org; auth=none
- References: <1446560861-31206-1-git-send-email-alan dot lawrence at arm dot com> <5649CAB4 dot 8010400 at arm dot com>
Hello Alan,
On 16 Nov 12:23, Alan Lawrence wrote:
> On 03/11/15 14:27, Alan Lawrence wrote:
> >This migrates the various reduction optabs in sse.md to use the reduce-to-scalar
> >form. I took the straightforward approach (equivalent to the migration code in
> >expr.c/optabs.c) of generating a vector temporary, using the existing code to
> >reduce to that, and extracting lane 0, in each pattern.
> >
> >Bootstrapped + check-gcc + check-g++.
> >
> >Ok for trunk?
Your patch is OK for trunk.
Sorry, for missing the patch.
--
Thanks, K
> >
> >gcc/ChangeLog:
> >
> > * config/i386/sse.md (reduc_splus_v8df): Rename to...
> > (reduc_plus_scal_v8df): ...here; reduce to temp and extract scalar.
> >
> > (reduc_splus_v4df): Rename to...
> > (reduc_plus_scal_v4df): ...here; reduce to temp and extract scalar.
> >
> > (reduc_splus_v2df): Rename to...
> > (reduc_plus_scal_v2df): ...here; reduce to temp and extract scalar.
> >
> > (reduc_splus_v16sf): Rename to...
> > (reduc_plus_scal_v16sf): ...here; reduce to temp and extract scalar.
> >
> > (reduc_splus_v8sf): Rename to...
> > (reduc_plus_scal_v8sf): ...here; reduce to temp and extract scalar.
> >
> > (reduc_splus_v4sf): Rename to...
> > (reduc_plus_scal_v4sf): ...here; reduce to temp and extract scalar.
> >
> > (reduc_<code>_<mode>, all 3 variants): Rename each to...
> > (reduc_<code>_scal_<mode>): ...here; reduce to temp and extract scalar.
> >
> > (reduc_umin_v8hf): Rename to...
> > (reduc_umin_scal_v8hf): ...here; reduce to temp and extract scalar.
> >---
> > gcc/config/i386/sse.md | 82 +++++++++++++++++++++++++++++++-------------------
> > 1 file changed, 51 insertions(+), 31 deletions(-)
> >