This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix obvious typo that breaks boot strap in delayed folding
- From: Andi Kleen <andi at firstfloor dot org>
- To: Ville Voutilainen <ville dot voutilainen at gmail dot com>
- Cc: schwab at linux-m68k dot org, "gcc-patches\ at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>
- Date: Mon, 16 Nov 2015 03:04:17 -0800
- Subject: Re: [PATCH] Fix obvious typo that breaks boot strap in delayed folding
- Authentication-results: sourceware.org; auth=none
- References: <CAFk2RUbApQ1E3Q93NS0TAc2hozjAYNekeq6baRWSscwCrvq-eQ at mail dot gmail dot com>
Ville Voutilainen <ville.voutilainen@gmail.com> writes:
>
> The proposed patch makes no sense. The assignment is intentional,
> the relevant flags of the element type are reflected onto the array type.
> Doing a comparison there instead of assignment will not have the
> desired effect.
Ok I changed it to an assignment.
> Maybe I'm dense, but why is there a warning that suggests adding
> parens around the assignment when it already has parens around it?
> Is that diagnostic over-eager?
Yes it seems broken.
I'm just going to use --disable-werror now, as apparently everybody else
does.
-Andi