This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix SH/FDPIC bad codegen with ssp enabled
- From: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- To: dalias at libc dot org
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sat, 14 Nov 2015 09:24:32 +0900 (JST)
- Subject: Re: [PATCH] Fix SH/FDPIC bad codegen with ssp enabled
- Authentication-results: sourceware.org; auth=none
- References: <20151113165653 dot GA11709 at brightrain dot aerifal dot cx>
Rich Felker <dalias@libc.org> wrote:
> The "chk_guard_add" pattern used for loading the GOT slot address for
> __stack_chk_guard hard-codes use of r12 as a fixed GOT register and
> thus is not suitable for FDPIC, where the saved initial value of r12
> from function entry is what we need.
The patch is OK. Committed as revision 230366.
> I would actually prefer removing this hack entirely if possible. I
> tried non-FDPIC with it disabled and did not experience any problems;
> I suspect it was written to work around a bug that no longer exists.
Even we don't see the problem without that, it'll be a latent
issue with the old reload, I think. When SH switches to LRA
completely, this should be revisit.
Regards,
kaz