This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR ipa/68035
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Martin Liška <mliska at suse dot cz>
- Cc: Jan Hubicka <hubicka at ucw dot cz>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 12 Nov 2015 19:40:00 +0100
- Subject: Re: [PATCH] Fix PR ipa/68035
- Authentication-results: sourceware.org; auth=none
- References: <563C6E86 dot 6040808 at suse dot cz> <20151106164358 dot GA93383 at kam dot mff dot cuni dot cz> <564460CB dot 90209 at suse dot cz>
> >> +
> >> + /* Initialize hash values if we are not in LTO mode. */
> >> + if (!in_lto_p)
> >> + item->get_hash ();
> >> }
> >
> > Hmm, what is the difference to the LTO mode here. I would have expected that all the items
> > was analyzed in both paths?
>
> Difference is that in case of the LTO mode, the hash value is read from streamed LTO file.
> On the other hand, in classic compilation mode we have to force the calculation as a hash value
> is computed lazily.
In this case we need to also handle cases where function/variable is born during WPA (i.e. produced
by earlier pass), so in_lto_p check looks wrong.
I will look at the updated patch.
Honza