This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 4b/4] [ARM] PR63870 Remove error for invalid lane numbers
- From: Charles Baylis <charles dot baylis at linaro dot org>
- To: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>
- Cc: Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, Alan Lawrence <alan dot lawrence at arm dot com>, Richard Earnshaw <rearnsha at arm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 12 Nov 2015 02:54:55 +0000
- Subject: Re: [PATCH 4b/4] [ARM] PR63870 Remove error for invalid lane numbers
- Authentication-results: sourceware.org; auth=none
- References: <1446942404-11561-1-git-send-email-charles dot baylis at linaro dot org> <1446942404-11561-6-git-send-email-charles dot baylis at linaro dot org> <5643250F dot 9000000 at arm dot com> <CADnVucD=LvKcUQcB0_zTPOsizqib151AF-k1M17m0yR3=DdOeA at mail dot gmail dot com> <56433028 dot 6070809 at arm dot com>
On 11 November 2015 at 12:10, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:
>
> On 11/11/15 12:08, Charles Baylis wrote:
>>
>> On 11 November 2015 at 11:22, Kyrill Tkachov <kyrylo.tkachov@arm.com>
>> wrote:
>>>
>>> Hi Charles,
>>>
>>> On 08/11/15 00:26, charles.baylis@linaro.org wrote:
>>>>
>>>> From: Charles Baylis <charles.baylis@linaro.org>
>>>>
>>>> <DATE> Charles Baylis <charles.baylis@linaro.org>
>>>>
>>>> * config/arm/neon.md (neon_vld1_lane<mode>): Remove error for
>>>> invalid
>>>> lane number.
>>>> (neon_vst1_lane<mode>): Likewise.
>>>> (neon_vld2_lane<mode>): Likewise.
>>>> (neon_vst2_lane<mode>): Likewise.
>>>> (neon_vld3_lane<mode>): Likewise.
>>>> (neon_vst3_lane<mode>): Likewise.
>>>> (neon_vld4_lane<mode>): Likewise.
>>>> (neon_vst4_lane<mode>): Likewise.
>>>>
>>> In this pattern the 'max' variable is now unused, causing a bootstrap
>>> -Werror failure on arm.
>>> I'll test a patch to fix it unless you beat me to it...
>>
>> Thanks for catching this.
>>
>> I have a patch, and have started a bootstrap. Unless you have
>> objections, I'll apply as obvious once the bootstrap is complete later
>> this afternoon.
>
>
> Yes, that's the exact patch I'm testing as well.
> I'll let you finish the bootstrap and commit it.
>> gcc/ChangeLog:
>>
>> 2015-11-11 Charles Baylis <charles.baylis@linaro.org>
>>
>> * config/arm/neon.md: (neon_vld2_lane<mode>): Remove unused max
>> variable.
>> (neon_vst2_lane<mode>): Likewise.
>> (neon_vld3_lane<mode>): Likewise.
>> (neon_vst3_lane<mode>): Likewise.
>> (neon_vld4_lane<mode>): Likewise.
>> (neon_vst4_lane<mode>): Likewise.
Applied as r230203 after successful bootstrap on arm-unknown-linux-gnueabihf.