This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 1/2][ARC] Add support for ARCv2 CPUs
- From: Joern Wolfgang Rennecke <gnu at amylaar dot uk>
- To: Claudiu Zissulescu <Claudiu dot Zissulescu at synopsys dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: Francois Bedard <Francois dot Bedard at synopsys dot com>, "jeremy dot bennett at embecosm dot com" <jeremy dot bennett at embecosm dot com>
- Date: Tue, 10 Nov 2015 14:01:12 +0000
- Subject: Re: [PATCH 1/2][ARC] Add support for ARCv2 CPUs
- Authentication-results: sourceware.org; auth=none
- References: <098ECE41A0A6114BB2A07F1EC238DE8966166409 at de02wembxa dot internal dot synopsys dot com> <562A7331 dot 7020605 at amylaar dot uk> <098ECE41A0A6114BB2A07F1EC238DE896616912A at de02wembxa dot internal dot synopsys dot com>
On 30/10/15 11:19, Claudiu Zissulescu wrote:
Hi,
Please find the updated patch. I will defer the secondary reload optimization which will use the ld instructions with LIMM, for the time being.
Apart from the gen_compare_reg change, the patch is OK.
If the v2 support mostly works like support for the other subtargets,
you may check it in without the gen_compare_reg
change.
If that change is required because of particular code paths taken with
the v2 port, you may check in the whole patch.
The operand-swapping in gen_compare_reg was not expected to be triggered
when re-generating a comparison,
as comparisons gleaned from existing instructions are supposed to
already have the operands in the right order.
Do you have a testcase that triggers the assert independently from the
v2 support?
If you can name a pre-existing testcase to trigger the assert, the patch
is approved for separate check-in.
If you have a new testcase, is it in a form and of a legal status that
it can be submitted for inclusion in the
gcc regression tests suite?