This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch AArch64] Switch constant pools to separate rodata sections.

From: Ramana Radhakrishnan <ramana dot radhakrishnan at foss dot arm dot com>
To: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Cc: Andreas Schwab <schwab at linux-m68k dot org>, James Greenhalgh <james dot greenhalgh at arm dot com>
Date: Mon, 9 Nov 2015 16:46:01 +0000
Subject: Re: [Patch AArch64] Switch constant pools to separate rodata sections.
Authentication-results: sourceware.org; auth=none
References: <5638E29D dot 6030704 at foss dot arm dot com> <20151103170952 dot GA5141 at arm dot com> <563A1597 dot 9060604 at foss dot arm dot com> <87611cd8eh dot fsf at igel dot home>

On 08/11/15 11:42, Andreas Schwab wrote:
> This is causing a bootstrap comparison failure in gcc/go/gogo.o.
> 
> Andreas.
> 

I've had a look at this for sometime this afternoon and the trigger is the aarch64_use_constant_blocks_p change which appears to be causing a bootstrap comparison failure because of differences to offsets in add instructions when built with debug and without debug. For now, in the interest of go bootstraps continuing on trunk - I'm proposing a patch that partially rolls back the change in aarch64_use_constant_blocks_p and will still look into the underlying issue.

Bootstrapped on aarch64-none-linux-gnu including (c,c++ and go) - testing finished ok.

Ok ?

Ramana

PR bootstrap/68256

* config/aarch64/aarch64.c (aarch64_use_constant_blocks_p): Return false.

Attachment: go-workaround.txt
Description: Text document

Follow-Ups:
- Re: [Patch AArch64] Switch constant pools to separate rodata sections.
  - From: James Greenhalgh

References:
- [Patch AArch64] Switch constant pools to separate rodata sections.
  - From: Ramana Radhakrishnan
- Re: [Patch AArch64] Switch constant pools to separate rodata sections.
  - From: James Greenhalgh
- Re: [Patch AArch64] Switch constant pools to separate rodata sections.
  - From: Ramana Radhakrishnan
- Re: [Patch AArch64] Switch constant pools to separate rodata sections.
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]