This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/6] Share code from fold_array_ctor_reference with fold.


On 11/04/2015 07:35 AM, Alan Lawrence wrote:
s/explicitely/explicitly/  And remove the '*' from the 2nd and 3rd lines
of the comment.

It looks like get_ctor_element_at_index has numerous formatting
problems.  In particular you didn't indent the braces across the board
properly.  Also check for tabs vs spaces issues please.

Yes, you are quite right, I'm not quite sure how those crept in. (Well, the
'explicitely' I am sure was a copy-paste error but the others!). Apologies...
Yea, the explicitely was in the original. I'd actually gone back to the original thinking the bogus formatting might have been in there too. But it looked reasonable.


I already committed the offending code as r229605, but here's a patch to clean
it up - does it look ok now?
Yes.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]