This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH c/c++] use explicit locations for some warnings in c-pragma.c
- From: Mike Stump <mikestump at comcast dot net>
- To: Manuel López-Ibáñez <lopezibanez at gmail dot com>
- Cc: Christophe Lyon <christophe dot lyon at linaro dot org>, Marek Polacek <polacek at redhat dot com>, Gcc Patch List <gcc-patches at gcc dot gnu dot org>, "Joseph S. Myers" <joseph at codesourcery dot com>, Jason Merrill <jason at redhat dot com>
- Date: Fri, 6 Nov 2015 13:17:23 -0800
- Subject: Re: [PATCH c/c++] use explicit locations for some warnings in c-pragma.c
- Authentication-results: sourceware.org; auth=none
- References: <CAESRpQAss9wY48rxjsVC_VHn5c2bC+ZKf4m6fvL-ZNVFLkmKEA at mail dot gmail dot com> <20150525195650 dot GY27320 at redhat dot com> <CAESRpQA=V4JmGTzOmJxgjCe+_mUMXdhMMVBnuGiDeW8LxOYi5A at mail dot gmail dot com> <CAKdteOYY1O50YLv7URgXX1Yiht=VPJvgT6Z8p2k6bUrDfb6pCw at mail dot gmail dot com> <CAESRpQCe5=ih8-kw-kMg7v+rxLHbfdr3VtGAfbyyPFJ=Fez+aQ at mail dot gmail dot com> <9BCE0DCA-FF55-4C94-ADA0-78AAE57CA26B at mrs dot kithrup dot com> <CAESRpQBAndAxL8xtUQQK5HTpNudR0bjQGdUQpP84KNXgyb9Bmw at mail dot gmail dot com>
On Nov 4, 2015, at 1:02 PM, Manuel López-Ibáñez <lopezibanez@gmail.com> wrote:
> On 4 November 2015 at 09:45, Mike Stump <mrs@mrs.kithrup.com> wrote:
>> in the top of the tree. This is bad as the same line appears in a PASS: and an XFAIL:. Each test case should be unique. Should it be updated to 64?
>
> I think it is sufficient to change it to:
>
> /* { dg-warning "24:missing" "wrong column" { xfail *-*-* } 2 } */
I tested this out, works just fine.
2015-11-06 Mike Stump <mikestump@comcast.net>
* gcc.dg/pragma-diag-5.c: Make test cases unique.
Index: testsuite/gcc.dg/pragma-diag-5.c
===================================================================
--- testsuite/gcc.dg/pragma-diag-5.c (revision 229885)
+++ testsuite/gcc.dg/pragma-diag-5.c (working copy)
@@ -1,6 +1,6 @@
/* { dg-do compile } */
#pragma GCC diagnostic /* { dg-warning "missing" "missing" } */
-/* { dg-warning "24:missing" "missing" { xfail *-*-* } 2 } */
+/* { dg-warning "24:missing" "wrong column" { xfail *-*-* } 2 } */
#pragma GCC diagnostic warn /* { dg-warning "24:expected" } */
Committed revision 229891.
Thanks for your help.