This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [gomp4 05/14] omp-low: set 'omp target entrypoint' only on entypoints
- From: Bernd Schmidt <bschmidt at redhat dot com>
- To: Alexander Monakov <amonakov at ispras dot ru>, Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Dmitry Melnik <dm at ispras dot ru>
- Date: Fri, 6 Nov 2015 15:05:05 +0100
- Subject: Re: [gomp4 05/14] omp-low: set 'omp target entrypoint' only on entypoints
- Authentication-results: sourceware.org; auth=none
- References: <1445366076-16082-1-git-send-email-amonakov at ispras dot ru> <1445366076-16082-6-git-send-email-amonakov at ispras dot ru> <20151021081451 dot GI478 at tucnak dot redhat dot com> <alpine dot LNX dot 2 dot 20 dot 1510301900180 dot 23484 at monopod dot intra dot ispras dot ru>
On 10/30/2015 05:44 PM, Alexander Monakov wrote:
+ /* Ignore "omp target entrypoint" here: OpenMP target region functions are
+ called from gomp_nvptx_main. The corresponding kernel entry is emitted
+ from write_omp_entry. */
}
I'm probably confused, but didn't we agree that this should be changed
so that the entry point isn't gomp_nvptx_main but instead something that
wraps a call to that function?
This patch creates a new "omp target entrypoint" annotation that appears
not to be used - it would be better to just not annotate a function if
it's not going to need entrypoint treatment. IMO a single type of
attribute should be sufficient for that.
Bernd