This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [2/2] OpenACC routine support


On 11/03/15 10:38, Jakub Jelinek wrote:
On Mon, Nov 02, 2015 at 02:23:19PM -0500, Nathan Sidwell wrote:
Here are the tests for the routine support.  The compiler tests check
invalid combinations of gang, worker, vector & seq.  The libgomp execution
tests check the expected partioning occurs within loops.  As  with the
reduction tests, these ones  are taken from the execution model loop tests.

I find the testsuite coverage insufficient, e.g. you don't have equivalent
of first half of declare-simd-2.C or declare-simd-2.c
(everything above #pragma omp declare simd inbranch notinbranch),
to verify that if acc routine is used without the (fnname) in it, then
it can't be followed by var definition and various other tokens.

d'oh! forgot to port those tests.  Easy fix.

ok with that added?

nathan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]