This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [AARCH64][PATCH 1/3] Implementing the variants of the vmulx_ NEON intrinsic
- From: James Greenhalgh <james dot greenhalgh at arm dot com>
- To: Bilyan Borisov <bilyan dot borisov at foss dot arm dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 3 Nov 2015 11:02:28 +0000
- Subject: Re: [AARCH64][PATCH 1/3] Implementing the variants of the vmulx_ NEON intrinsic
- Authentication-results: sourceware.org; auth=none
- References: <5633387F dot 6050000 at foss dot arm dot com>
On Fri, Oct 30, 2015 at 09:29:35AM +0000, Bilyan Borisov wrote:
> In this patch from the series, a single new md pattern is added: the one for
> fmulx, from which all necessary __builtin functions are derived.
>
> Several intrinsics were refactored to use the new __builtin functions as some
> of them already had an assembly block implementation. The rest, which had no
> existing implementation, were also added. A single intrinsic was removed:
> vmulx_lane_f32, since there was no test case that covered it and, moreover,
> its implementation was wrong: it was in fact implementing vmulxq_lane_f32.
>
> In addition, test cases for all new intrinsics were added. Tested on targets
> aarch64-none-elf and aarch64_be-none-elf.
This is OK for trunk.
As you don't yet have commit rights, I've committed it on your behalf
as revision 229702.
I made some small modifications to your ChangeLog. We normally use
"Likewise." rather than "Same." And the content of each line is a short
description of what changed, rather than why it changed. Additionally,
it is usually best to put the name of the thing that was changed, as this
will be what people grep for.
In the end, this was the log I committed:
gcc/
2015-11-03 Bilyan Borisov <bilyan.borisov@arm.com>
* config/aarch64/aarch64-simd-builtins.def (fmulx): New.
* config/aarch64/aarch64-simd.md (aarch64_fmulx<mode>): New.
* config/aarch64/arm_neon.h (vmulx_f32): Rewrite to call fmulx
builtin.
(vmulxq_f32): Likewise.
(vmulx_f64): New.
(vmulxq_f64): Rewrite to call fmulx builtin.
(vmulxs_f32): Likewise.
(vmulxd_f64): Likewise.
(vmulx_lane_f32): Remove.
* config/aarch64/iterators.md (UNSPEC): Add fmulx.
gcc/testsuite/
2015-11-03 Bilyan Borisov <bilyan.borisov@arm.com>
* gcc/testsuite/gcc.target/aarch64/simd/vmulx_f32_1.c: New.
* gcc/testsuite/gcc.target/aarch64/simd/vmulx_f64_1.c: New.
* gcc/testsuite/gcc.target/aarch64/simd/vmulxq_f32_1.c: New.
* gcc/testsuite/gcc.target/aarch64/simd/vmulxq_f64_1.c: New.
* gcc/testsuite/gcc.target/aarch64/simd/vmulxs_f32_1.c: New.
* gcc/testsuite/gcc.target/aarch64/simd/vmulxd_f64_1.c: New.
Thanks,
James