This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 5/5] remove usage of ADJUST_FIELD_ALIGN in encoding.c

On 10/30/2015 01:47 PM, Richard Biener wrote:

On Fri, Oct 30, 2015 at 1:28 PM, Bernd Schmidt <bschmidt@redhat.com> wrote:


it's not target independent code.  Are you suggesting to add a config/
to libobjc?  IMHO for a not really mantained frontend / target lib that's
an excessive requirement.



If necessary, then yes that would be a better solution.

Even just keeping the abstraction of the macro and putting definitions of it
inside #ifdef at the top of the file would be an improvement over the
submitted patch, but IMO still not really compatible with our standards.


I agree, that would make the source of the copy more obvious.
If we go down that path, there's another minimum requirement - adjust the docs to say that the macro must be defined in two places. That's my main worry, someone creating a new port, completely oblivious that they'd have to modify library code for it to work. 


Bernd
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]