Re: [gomp4, committed] Add goacc/kernels-acc-on-device.c

[Thomas Schwinge <thomas at codesourcery dot com>]

Hi Tom!

On Tue, 13 Oct 2015 17:49:21 +0200, Tom de Vries <Tom_deVries@mentor.com> wrote:
> On 12/10/15 14:52, Tom de Vries wrote:
> > On 12/10/15 12:49, Thomas Schwinge wrote:
> >> On Sat, 10 Oct 2015 12:49:01 +0200, Tom de
> >> Vries<Tom_deVries@mentor.com>  wrote:
> >>> >--- /dev/null
> >>> >+++ b/gcc/testsuite/c-c++-common/goacc/kernels-acc-on-device.c
> >>> >@@ -0,0 +1,39 @@
> >>> >+/* { dg-additional-options "-O2" } */
> >>> >+
> >>> >+#include <openacc.h>
> >
> > Hi Thomas,
> >
> >> That doesn't work (at least in build-tree testing), as gcc/testsuite/ is
> >> not set up to look for header files in [target]/libgomp/:
> >>
> >> [...]/source-gcc/gcc/testsuite/c-c++-common/goacc/kernels-acc-on-device.c:3:21:
> >> fatal error: openacc.h: No such file or directory
> >>      compilation terminated.
> >>      compiler exited with status 1

> As a follow-up patch, I've factored the code into a mockup openacc.h, 
> now shared by several test-cases.

> Factor out goacc/openacc.h
> 
> 2015-10-13  Tom de Vries  <tom@codesourcery.com>
> 
> 	* c-c++-common/goacc/openacc.h: New header file, factored out of ...
> 	* c-c++-common/goacc/kernels-acc-on-device.c: ... here.
> 	* c-c++-common/goacc/acc_on_device-2-off.c: Use openacc.h.
> 	* c-c++-common/goacc/acc_on_device-2.c: Same.

As a clean-up, and to move acc_on_device testing to where that OpenACC
Runtime Library routine is actually defined (libgomp's openacc.h), Nathan
has just removed this stub openacc.h header file, and also the test files
listed just above, plus the
gcc/testsuite/c-c++-common/goacc/kernels-acc-on-device-2.c that you added
later, see:
<http://news.gmane.org/find-root.php?message_id=%3C56327E51.1090507%40acm.org%3E>
(gomp-4_0-branch),
<http://news.gmane.org/find-root.php?message_id=%3C5632B856.4050509%40acm.org%3E>
(trunk).  If the kernels tests are still important (they tested ICEs, as
far as I remember), you'll have to re-instantiate these in
libgomp/testsuite/, or using __builtin_acc_on_device in gcc/testsuite/.


GrÃÃe
 Thomas

Attachment: signature.asc
Description: PGP signature