This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [gomp4 04/14] nvptx: fix output of _Bool global variables
- From: Alexander Monakov <amonakov at ispras dot ru>
- To: Bernd Schmidt <bschmidt at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Jakub Jelinek <jakub at redhat dot com>, Dmitry Melnik <dm at ispras dot ru>
- Date: Wed, 28 Oct 2015 21:06:23 +0300 (MSK)
- Subject: Re: [gomp4 04/14] nvptx: fix output of _Bool global variables
- Authentication-results: sourceware.org; auth=none
- References: <1445366076-16082-1-git-send-email-amonakov at ispras dot ru> <1445366076-16082-5-git-send-email-amonakov at ispras dot ru> <5626A898 dot 5000703 at redhat dot com> <alpine dot LNX dot 2 dot 20 dot 1510202351250 dot 23517 at monopod dot intra dot ispras dot ru> <alpine dot LNX dot 2 dot 20 dot 1510281941030 dot 13239 at monopod dot intra dot ispras dot ru> <5630FE4D dot 8040803 at redhat dot com> <alpine dot LNX dot 2 dot 20 dot 1510282029550 dot 13239 at monopod dot intra dot ispras dot ru> <56310812 dot 6090402 at redhat dot com> <alpine dot LNX dot 2 dot 20 dot 1510282049310 dot 13239 at monopod dot intra dot ispras dot ru> <56310D12 dot 7040904 at redhat dot com>
On Wed, 28 Oct 2015, Bernd Schmidt wrote:
> Ok, so adjust the if condition for non-integral types - make it false if the
> size of the struct is smaller than the pointer type.
I'm afraid it's an insufficient fix: it would remain broken for size-12
structs (containing 3 int fields, for example): they would be emitted with
size 16 instead.
(and as far as I see I can't make the condition false anyway, we still need
to pick some PTX type when emitting a struct)
Alexander