This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v4] SH FDPIC backend support
- From: Rich Felker <dalias at libc dot org>
- To: Oleg Endo <oleg dot endo at t-online dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 26 Oct 2015 22:47:06 -0400
- Subject: Re: [PATCH v4] SH FDPIC backend support
- Authentication-results: sourceware.org; auth=none
- References: <20151021034138 dot GA4087 at brightrain dot aerifal dot cx> <1445433471 dot 5521 dot 100 dot camel at t-online dot de> <20151021201510 dot GV8645 at brightrain dot aerifal dot cx> <20151023063221 dot GI8645 at brightrain dot aerifal dot cx> <1445783331 dot 8060 dot 3 dot camel at t-online dot de>
On Sun, Oct 25, 2015 at 11:28:51PM +0900, Oleg Endo wrote:
> On Fri, 2015-10-23 at 02:32 -0400, Rich Felker wrote:
> > Here's my updated version of the FDPIC patch with all requested
> > changes made and Changelog added. I've included all the original
> > authors. This is my first time writing such an extensive Changelog
> > entry so please let me know if there are things I got wrong.
>
> I took the liberty and fixed some minor formatting trivia and extracted
> functions sh_emit_storesi and sh_emit_storehi which are used in
> sh_trampoline_init to effectively memcpy code into the trampoline
> area. Can you please check it? If it's OK I'll commit the attached
> patch to trunk.
Is there anything in particular you'd like me to check? It builds fine
for fdpic target, successfully compiles musl libc.so, and busybox runs
with the resulting libc.so. I did a quick visual inspection of the
diff between my version and yours too and didn't see anything that
looked suspicious to me.
Rich