This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 7/9] ENABLE_CHECKING refactoring: middle-end, LTO FE


On 10/26/2015 11:14 AM, Bernd Schmidt wrote:
On 10/26/2015 05:59 PM, Jeff Law wrote:
I left it as-is.  Obviously if you really want the unnecessary braces
squashed out, we can do that.

It's not a rule I particularly care about myself, but I'm flagging stuff
like this for the sake of consistency.
Noted.


Don't change the whitespace here. Looks like you probably removed a page
break.
Not obvious where it got lost as there's no filename in the review
comments :-)

Oops. I think it was one of the sel-sched files.
I'll do a looksie over things for undesirable whitespace changes.

At least some of the CHECKING_P vs flag_checking thingies are for things that are used outside the compiler proper. ie things that don't have the options structure. The pretty-printer and diagnostics stuff was of that nature. So I'm keeping CHECKING_P rather than flag_checking in those.

Jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]