This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [OpenACC 0/7] host_data construct
- From: James Norris <jnorris at codesourcery dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Nathan Sidwell <Nathan_Sidwell at mentor dot com>, Jakub Jelinek <jakub at redhat dot com>
- Date: Thu, 22 Oct 2015 15:42:31 -0500
- Subject: Re: [OpenACC 0/7] host_data construct
- Authentication-results: sourceware.org; auth=none
- References: <56293476 dot 5020801 at codesourcery dot com> <alpine dot DEB dot 2 dot 10 dot 1510222024190 dot 23141 at digraph dot polyomino dot org dot uk>
To all,
On 10/22/2015 03:36 PM, Joseph Myers wrote:
I think this patch is small enough, and the pieces insufficiently
self-contained, that splitting it up rather than posting as one patch just
makes it harder to understand. My strong preference is that the same
patch that introduces a feature should also add the testcases for that
feature, for example - they should not be split out (that's not even a
split by reviewer, testcases are critical to reviewing functionality
patches).
Okay, I'll rewrite the posting and submit it with a single patch
as a response to the initial posting. I'll also re-write the comments
as they have been pointed out by Nathan as being too terse.
My apologies for wasting people's time.
Jim