This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 0/4] OpenMP 4.0 offloading to Intel MIC
- From: Ilya Verbin <iverbin at gmail dot com>
- To: Thomas Schwinge <thomas at codesourcery dot com>, Jakub Jelinek <jakub at redhat dot com>
- Cc: Kirill Yukhin <kirill dot yukhin at gmail dot com>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 22 Oct 2015 21:26:37 +0300
- Subject: Re: [PATCH 0/4] OpenMP 4.0 offloading to Intel MIC
- Authentication-results: sourceware.org; auth=none
- References: <20141021171323 dot GA47586 at msticlxl57 dot ims dot intel dot com> <87k31jzye3 dot fsf at kepler dot schwinge dot homeip dot net>
On Mon, Dec 22, 2014 at 13:01:40 +0100, Thomas Schwinge wrote:
> By chance (when tracking down a different problem), I've found the
> following. Would you please check whether that's a real problem in
> liboffloadmic, or its libgomp plugin, or just a mis-diagnosis by
> Valgrind?
>
> ==21327== Syscall param write(buf) points to uninitialised byte(s)
Finally we have investigated this :) Valgrind warns about uninitialized bytes,
inserted into the struct for alignment. It's possible to avoid the warning by
the patch bellow. Should I commit it, or just leave it as is?
diff --git a/liboffloadmic/runtime/offload_host.cpp b/liboffloadmic/runtime/offload_host.cpp
index d04233f..66c2a01 100644
--- a/liboffloadmic/runtime/offload_host.cpp
+++ b/liboffloadmic/runtime/offload_host.cpp
@@ -2425,6 +2425,7 @@ bool OffloadDescriptor::setup_misc_data(const char *name)
misc_data_size);
if (m_func_desc == NULL)
LIBOFFLOAD_ERROR(c_malloc);
+ memset (m_func_desc, 0, m_func_desc_size + misc_data_size);
m_func_desc->console_enabled = console_enabled;
m_func_desc->timer_enabled = offload_report_enabled &&
(timer_enabled || offload_report_level);
-- Ilya