This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 09/13] Fix PR 66768

From: Richard Henderson <rth at redhat dot com>
To: Jeff Law <law at redhat dot com>, gcc-patches at gcc dot gnu dot org
Cc: richard dot guenther at gmail dot com
Date: Wed, 21 Oct 2015 07:51:23 -1000
Subject: Re: [PATCH v2 09/13] Fix PR 66768
Authentication-results: sourceware.org; auth=none
References: <1445376433-14658-1-git-send-email-rth at redhat dot com> <1445376433-14658-10-git-send-email-rth at redhat dot com> <56279958 dot 2010303 at redhat dot com>

On 10/21/2015 03:55 AM, Jeff Law wrote:

On 10/20/2015 03:27 PM, Richard Henderson wrote:

---
  gcc/tree-ssa-address.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

I think this change is fine.  Needs a testcase though.

I'll also note you need ChangeLogs for all these patches.  I know you know
that, so it's just a reminder that they're often helpful for reviewers.

I wrote them for v1, but then failed to copy them over into the messages forv2. Sorry about that. Certainly they'll be present in the actual commit.

r~

References:
- [PATCH v2 00/13] Address space support for x86
  - From: Richard Henderson
- [PATCH v2 09/13] Fix PR 66768
  - From: Richard Henderson
- Re: [PATCH v2 09/13] Fix PR 66768
  - From: Jeff Law

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]