This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] gcc/ira.c: Check !HAVE_FP_INSTEAD_INSNS when frame pointer is needed and as global register
- From: Chen Gang <xili_gchen_5257 at hotmail dot com>
- To: Bernd Schmidt <bschmidt at redhat dot com>, Jeff Law <law at redhat dot com>, Richard Henderson <rth at redhat dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 13 Oct 2015 06:32:16 +0800
- Subject: Re: [PATCH] gcc/ira.c: Check !HAVE_FP_INSTEAD_INSNS when frame pointer is needed and as global register
- Authentication-results: sourceware.org; auth=none
- References: <561A7D5C dot 40409 at hotmail dot com> <COL130-W507E81834CE1C264271E3BB9320 at phx dot gbl> <561B902A dot 3090609 at redhat dot com>
On 10/12/15 18:49, Bernd Schmidt wrote:
> On 10/11/2015 05:16 PM, Chen Gang wrote:
>> For some architectures (e.g. bfin), when this case occurs, they will use
>> another instructions instead of frame pointer (e.g. LINK for bfin), so
>> they can still generate correct output assembly code.
>
> What is "this case"? I don't think you have explained the problem you are trying to solve.
>
It is about Bug65804. I found it when building Linux bfin kernel, and
the original old version gcc can build kernel successfully.
But since the git commit "e52beba PR debug/54694", it will be failed: it
intends to check failure during building time. But for bfin, it has LINK
insn instead of, so it is still OK, and gcc should not report failure.
>> 2015-10-11 Chen Gang <gang.chen.5i5j@gmail.com>
>>
>> gcc/
>> * config.in: Add HAVE_FP_INSTEAD_INSNS.
>> * configure: Check HAVE_FP_INSTEAD_INSNS to set 0 or 1.
>
> And of course, that should not be a configure check. If at all, use a target hook.
>
OK, thanks. If we really need to fix it, which target hook should I use?
(or do we need a new target hook?)
Thanks.
--
Chen Gang (éå)
Open, share, and attitude like air, water, and life which God blessed