This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/3] [ARM] PR63870 Mark lane indices of vldN/vstN with appropriate qualifier

From: Alan Lawrence <alan dot lawrence at arm dot com>
To: "charles dot baylis at linaro dot org" <charles dot baylis at linaro dot org>, Kyrylo Tkachov <Kyrylo dot Tkachov at arm dot com>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Mon, 12 Oct 2015 11:50:03 +0100
Subject: Re: [PATCH 2/3] [ARM] PR63870 Mark lane indices of vldN/vstN with appropriate qualifier
Authentication-results: sourceware.org; auth=none
References: <1444175989-24944-1-git-send-email-charles dot baylis at linaro dot org> <1444175989-24944-3-git-send-email-charles dot baylis at linaro dot org>

On 07/10/15 00:59, charles.baylis@linaro.org wrote:

diff --git a/gcc/config/arm/neon.md b/gcc/config/arm/neon.md
index 2667866..251afdc 100644
--- a/gcc/config/arm/neon.md
+++ b/gcc/config/arm/neon.md
@@ -4261,8 +4261,9 @@ if (BYTES_BIG_ENDIAN)
                      UNSPEC_VLD1_LANE))]
    "TARGET_NEON"
  {
-  HOST_WIDE_INT lane = INTVAL (operands[3]);
+  HOST_WIDE_INT lane = ENDIAN_LANE_N(<MODE>mode, INTVAL (operands[3]));
    HOST_WIDE_INT max = GET_MODE_NUNITS (<MODE>mode);
+  operands[3] = GEN_INT (lane);
    if (lane < 0 || lane >= max)
      error ("lane out of range");

I'm just wondering whether these 'lane out of range' error messages can ever betriggered now we have all the other checking? Can we now remove them (perhaps ina followup patch)?


Cheers, Alan

References:
- [PATCH v2 0/3] [ARM] PR63870 vldN_lane/vstN_lane error messages
  - From: charles . baylis
- [PATCH 2/3] [ARM] PR63870 Mark lane indices of vldN/vstN with appropriate qualifier
  - From: charles . baylis

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]