This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/5] completely_scalarize arrays as well as records
- From: Richard Biener <rguenther at suse dot de>
- To: Alan Lawrence <alan dot lawrence at arm dot com>
- Cc: Christophe Lyon <christophe dot lyon at linaro dot org>, "martin dot jambor at suse dot cz" <martin dot jambor at suse dot cz>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jeff Law <law at redhat dot com>
- Date: Fri, 28 Aug 2015 15:01:38 +0200 (CEST)
- Subject: Re: [PATCH 2/5] completely_scalarize arrays as well as records
- Authentication-results: sourceware.org; auth=none
- References: <20150825214232 dot GB12831 at virgil dot suse dot cz> <1440690217-24461-1-git-send-email-alan dot lawrence at arm dot com> <CAKdteOYL373pKpYB2R=6e+mLr5c=EfermXZshSmzOC-B9St6rA at mail dot gmail dot com> <alpine dot LSU dot 2 dot 11 dot 1508280946130 dot 4884 at zhemvz dot fhfr dot qr> <CAKdteOY69rzcpqrQm6NnC1XAzgmWi2-KJD3g=wxG=iZpMnu0+A at mail dot gmail dot com> <55E03315 dot 7080205 at arm dot com>
On Fri, 28 Aug 2015, Alan Lawrence wrote:
> Christophe Lyon wrote:
> >
> > I asked because I assumed that Alan saw it pass in his configuration.
>
>
> Bah. No - I now discover a problem in my C++ testsuite setup that was causing
> a large number of tests to not be executed. I see the problem too now,
> investigating....
Btw, your patch broke Ada:
+===========================GNAT BUG
DETECTED==============================+
| 6.0.0 20150828 (experimental) (x86_64-pc-linux-gnu) GCC error:
|
| in completely_scalarize, at tree-sra.c:996
|
| Error detected around ../rts/a-coorse.ads:46:24
|
case ARRAY_TYPE:
{
tree elemtype = TREE_TYPE (decl_type);
tree elem_size = TYPE_SIZE (elemtype);
gcc_assert (elem_size && tree_fits_uhwi_p (elem_size));
int el_size = tree_to_uhwi (elem_size);
gcc_assert (el_size);
tree minidx = TYPE_MIN_VALUE (TYPE_DOMAIN (decl_type));
tree maxidx = TYPE_MAX_VALUE (TYPE_DOMAIN (decl_type));
gcc_assert (TREE_CODE (minidx) == INTEGER_CST
&& TREE_CODE (maxidx) == INTEGER_CST);
obviously you missed VLAs. min/max value can also be NULL.
Richard.