This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Fix vec_shr define_expand
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Pat Haugen <pthaugen at linux dot vnet dot ibm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 25 Aug 2015 11:04:20 -0400
- Subject: Re: [PATCH, rs6000] Fix vec_shr define_expand
- Authentication-results: sourceware.org; auth=none
- References: <55DC7837 dot 1020404 at linux dot vnet dot ibm dot com>
On Tue, Aug 25, 2015 at 10:14 AM, Pat Haugen
<pthaugen@linux.vnet.ibm.com> wrote:
> The following patch fixes the vec_shr expander to do a shift instead of a
> rotate. CPU2006 benchmark 482.sphinx3 recently started failing due to this
> issue. Bootstrapped and tested on ppc64/ppc64le with no new regressions. Ok
> for trunk? And ok for 4.9/5 (with equivalent change to vec_shl expander
> which exists in those releases) after bootstrap/regtest?
>
> -Pat
>
>
> 2015-08-25 Pat Haugen <pthaugen@us.ibm.com>
>
> * config/rs6000/vector.md (vec_shr_<mode>): Fix to do a shift
> instead of a rotate.
>
> gcc/testsuite:
> * gcc.target/powerpc/vec-shr.c: New.
This is okay.
As Peter and I noticed
+ zero_reg = gen_reg_rtx(<MODE>mode);
This needs a space after gen_rtx_rtx.
Thanks, David