This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCH] MIPS: Add the lo register to the clobber list in the madd-8.c and msub-8.c testcases
- From: "Moore, Catherine" <Catherine_Moore at mentor dot com>
- To: Andrew Bennett <Andrew dot Bennett at imgtec dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- Date: Mon, 24 Aug 2015 21:42:11 +0000
- Subject: RE: [PATCH] MIPS: Add the lo register to the clobber list in the madd-8.c and msub-8.c testcases
- Authentication-results: sourceware.org; auth=none
- References: <0DA23CC379F5F945ACB41CF394B98277210F9AA5 at LEMAIL01 dot le dot imgtec dot org>
HI Andrew,
> -----Original Message-----
> From: Andrew Bennett [mailto:Andrew.Bennett@imgtec.com]
> Sent: Tuesday, July 21, 2015 10:56 AM
> To: gcc-patches@gcc.gnu.org
> Cc: Matthew Fortune; Moore, Catherine
> Subject: [PATCH] MIPS: Add the lo register to the clobber list in the madd-8.c
> and msub-8.c testcases
>
> Hi,
>
> The lo register is not listed in the clobber list in the inline asm statement for
> the madd-8.c and msub-8.c testcases. This means that when building for the
> n64 ABI GCC is free to use the lo register instead of the stack when
> saving/restoring the clobbered registers. Then then means that it decides to
> use the msub/madd instruction to perform the "x - y * z" operation rather
> than using mul; addu/subu which the test is looking for.
>
> The following patch therefore adds the lo register to the clobber list for the
> madd-8.c and msub-8.c testcases. The patch has been tested on the mti/img
> elf/linux-gnu toolchains, and there have been no new regressions.
>
> The patch and ChangeLog are below.
>
> Ok to commit?
>
>
Yes, this looks OK.