This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fwd: [PATCH 3/4] Add libgomp plugin for Intel MIC
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Maxim Blumental <bvmaks at gmail dot com>
- Cc: David Malcolm <dmalcolm at redhat dot com>, Kirill Yukhin <kirill dot yukhin at gmail dot com>, Ilya Verbin <iverbin at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 24 Aug 2015 10:45:03 +0200
- Subject: Re: Fwd: [PATCH 3/4] Add libgomp plugin for Intel MIC
- Authentication-results: sourceware.org; auth=none
- References: <20141021171323 dot GA47586 at msticlxl57 dot ims dot intel dot com> <20141021172413 dot GD47586 at msticlxl57 dot ims dot intel dot com> <878uaq68fn dot fsf at kepler dot schwinge dot homeip dot net> <20150723185029 dot GA48606 at msticlxl57 dot ims dot intel dot com> <20150724080106 dot GH1780 at tucnak dot redhat dot com> <1437747492 dot 15571 dot 87 dot camel at surprise> <CACy_Q+xHdro9EZT0H0z7pMGaFKZooyg++mN2fVGjKoM0W8wAXw at mail dot gmail dot com> <CACy_Q+yYnrFw4U_Lt7RQ_NUB=xPZF+xrZvOyUyKpjNMqUajt=g at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Aug 06, 2015 at 05:34:56PM +0300, Maxim Blumental wrote:
> Applied the idea with python script alternative. Review, please.
> 2015-07-28 Maxim Blumenthal <maxim.blumenthal@intel.com>
>
> * configure.ac: Add a check for xxd or python presence when the target
> is intelmic or intelmicemul.
> * configure: Regenerate.
> * liboffloadmic/plugin/Makefile.am: Add a condition into
> make_target_image.h generating code. This condition performs an
> action with either xxd or a special python script during the
> generating.
> * liboffloadmic/plugin/xxd.py: New file.
> * liboffloadmic/plugin/Makefile.in: Regenerate.
I still don't like this, there should be no `which ...` uses in the
Makefile.
Instead, use AC_CHECK_PROG/AC_CHECK_PROGS in configure.ac, for python
perhaps search for python python2 python3 or what is common in the python
land. And prepare the command line to use in the Makefile.am in configure
too, then AC_SUBST it and use the variable in there (and the variable will
use $@ etc.).
Jakub