This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCH][MIPS] Fix register renaming in the interrupt handlers
- From: "Moore, Catherine" <Catherine_Moore at mentor dot com>
- To: Matthew Fortune <Matthew dot Fortune at imgtec dot com>, Robert Suchanek <Robert dot Suchanek at imgtec dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 13 Aug 2015 17:38:05 +0000
- Subject: RE: [PATCH][MIPS] Fix register renaming in the interrupt handlers
- Authentication-results: sourceware.org; auth=none
- References: <B5E67142681B53468FAF6B7C31356562441B01AD at hhmail02 dot hh dot imgtec dot org> <6D39441BF12EF246A7ABCE6654B02353212267CC at LEMAIL01 dot le dot imgtec dot org>
> -----Original Message-----
> From: Matthew Fortune [mailto:Matthew.Fortune@imgtec.com]
> Sent: Thursday, August 13, 2015 7:20 AM
> To: Robert Suchanek; Moore, Catherine
> Cc: gcc-patches@gcc.gnu.org
> Subject: RE: [PATCH][MIPS] Fix register renaming in the interrupt handlers
>
> I'd like to give Catherine chance to review this, I notice a couple of formatting
> nits in the test case:
Yes, this patch is OK with Matthew's suggested changes.
Thanks,
Catherine
>
> Robert Suchanek <Robert.Suchanek@imgtec.com> writes:
> > a/gcc/testsuite/gcc.target/mips/interrupt_handler-bug-1.c
> > b/gcc/testsuite/gcc.target/mips/interrupt_handler-bug-1.c
> > new file mode 100644
> > index 0000000..877d00c
> > --- /dev/null
> > +++ b/gcc/testsuite/gcc.target/mips/interrupt_handler-bug-1.c
> > @@ -0,0 +1,12 @@
> > +/* { dg-options "-funroll-loops" } */ int foo; int bar;
> > +
> > +void __attribute__ ((interrupt)) isr(void) {
>
> Newline for function name and whitespace before args
>
> > + if (!foo)
> > + {
>
> Double space indent for brace or remove them entirely as it is single
> statement.
>
> > + while (bar & 0xFF30);
> > + }
> > +}
> > +/* { dg-final { scan-assembler-not "\\\$8" } } */
>
> Thanks,
> Matthew
>
>