This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][RTL-ifcvt] Improve conditional select ops on immediates
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jeff Law <law at redhat dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Mon, 10 Aug 2015 11:43:11 +0200
- Subject: Re: [PATCH][RTL-ifcvt] Improve conditional select ops on immediates
- Authentication-results: sourceware.org; auth=none
- References: <CAFULd4aZ21S9=hRi9A0LT+AmaMMQG5PQw_nLyi57DLgKR5_2RA at mail dot gmail dot com> <55BF666A dot 5000008 at arm dot com> <CAFULd4ZtOT=YHM5vyy09ELcP_8MZZ9fTV6Mu_mEKqVJinL4sMA at mail dot gmail dot com> <55BF6FE5 dot 8020902 at arm dot com> <CAFULd4YaAEu342Up_wZLZf2OLr4+dRQ06+mrCfQS_MNy6ZMAVQ at mail dot gmail dot com> <55BF8AAF dot 7060101 at arm dot com> <CAFULd4bcni_Cu4D6ikFL=hbzRa__2xKjuPwd3cAnfLecnyzRkw at mail dot gmail dot com> <55BF8E7F dot 2010108 at arm dot com> <55BFA2DB dot 1040507 at arm dot com> <CAFULd4bEePWJ+dhw5p32OKx+oTuOWnw3HqVFz59o5_w_ocd-8g at mail dot gmail dot com> <55C07B81 dot 4070703 at arm dot com> <55C87093 dot 1090307 at arm dot com>
On Mon, Aug 10, 2015 at 11:36 AM, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:
>>>> I'm testing a patch that fix the testcases on x86_64 and does not
>>>> harm codegen on aarch64. Feel free to file a PR and assign it to me.
>>>
>>> PR67103 [1]
>>>
>>> [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67103
>>
>> Thanks,
>> Here's the patch to move that transformation from
>> noce_try_store_flag_constants
>> to noce_try_cmove after the target-specific expansion has had a go.
>>
>> This fixes the testcases for me on x86_64.
>> In i386.exp I only see:
>> FAIL: gcc.target/i386/pr49781-1.c scan-assembler-not lea[lq]?[
>> \t]\\((%|)r[a-z0-9]*
>> FAIL: gcc.target/i386/pr61403.c scan-assembler blend
>>
>> which were there before my patch.
>> Bootstrap and testing on x86_64, arm and aarch64 is successful for me.
>>
>> Is this ok?
>
>
> Ping.
> Uros, does the codegen with this patch look ok to you?
Yes, the code of previously failing testcases looks OK.
You will need an approval from rtl-optimization maintainer, though.
Uros.