This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] [AVX512F] Add scatter support for vectorizer
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Richard Biener <rguenther at suse dot de>
- Cc: Petr Murzin <petrmurzin1 at gmail dot com>, Kirill Yukhin <kirill dot yukhin at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 4 Aug 2015 14:42:21 +0200
- Subject: Re: [PATCH] [AVX512F] Add scatter support for vectorizer
- Authentication-results: sourceware.org; auth=none
- References: <CANDVG5j78o_wS+wZZ4qe9-U80OVRZenRtL31r+5KQEB-+qLT1Q at mail dot gmail dot com> <alpine dot LSU dot 2 dot 11 dot 1508041351040 dot 19642 at zhemvz dot fhfr dot qr>
On Tue, Aug 4, 2015 at 2:15 PM, Richard Biener <rguenther@suse.de> wrote:
>> This patch adds scatter support for vectorizer (for AVX512F
>> instructions). Please have a look. Is it OK for trunk?
>
> +/* Target builtin that implements vector scatter operation. */
> +DEFHOOK
> +(builtin_scatter,
> + "",
> + tree,
> + (const_tree vectype, const_tree index_type, int scale),
> + NULL)
>
> please add documentation inline here, like for builtin_gather,
> and let tm.texi be auto-populated.
>
> Note that the i386 changes need target maintainer approval, CCing
> Uros.
As said many times, please don't mix middle-end and target parts into
one patch. Middle-end part (usually algorithmic one) has to be
discussed, reviewed and approved first, and at that stage, the target
part can be used as an implementation example. Only *after* approval
of the middle-end part, target part can be reviewed.
Not to mention that every part has different reviews, so the review of
the patch can stall due to this fact.
Uros.