This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][AArch64][3/14] Refactor option override code
- From: James Greenhalgh <james dot greenhalgh at arm dot com>
- To: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>
- Date: Mon, 3 Aug 2015 10:59:43 +0100
- Subject: Re: [PATCH][AArch64][3/14] Refactor option override code
- Authentication-results: sourceware.org; auth=none
- References: <55A7CBC5 dot 3030201 at arm dot com> <20150720164426 dot GA20088 at arm dot com> <55B1F59A dot 9010309 at arm dot com>
On Fri, Jul 24, 2015 at 09:21:46AM +0100, Kyrill Tkachov wrote:
>
> Thanks for the review, here's an updated version.
> In the end, I chose to retain the use alloca (other patches in the series
> are reworked to use it too).
>
> How's this?
A nit or two from code you were moving or that got caught up in the diff,
but otherwise OK to commit with the issues highlighted below fixed up.
>
> - aarch64_build_bitmask_table ();
> +/* Validate a command-line -mcpu option. Parse the cpu and extensions (if any)
> + specified in STR and throw errors if appropriate. Put the results if
> + they are valid in RES and ISA_FLAGS. */
> +static void
> +aarch64_validate_mcpu (const char *str, const struct processor **res,
> + unsigned long *isa_flags)
Newline between comment and function.
> +/* Validate a command-line -march option. Parse the arch and extensions
> + (if any) specified in STR and throw errors if appropriate. Put the
> + results, if they are valid, in RES and ISA_FLAGS. */
> +static void
> +aarch64_validate_march (const char *str, const struct processor **res,
> + unsigned long *isa_flags)
And here.
> +/* Validate a command-line -mtune option. Parse the cpu
> + specified in STR and throw errors if appropriate. Put the
> + result, if it is valid, in RES. */
> +static void
> +aarch64_validate_mtune (const char *str, const struct processor **res)
And here.
Thanks,
James