This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, i386]: Fix PR 66648, incorrect memcpy expansion with unrolled_loop strategy at -O2
- From: Renlin Li <renlin dot dev at gmail dot com>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 30 Jul 2015 17:01:22 +0100
- Subject: Re: [PATCH, i386]: Fix PR 66648, incorrect memcpy expansion with unrolled_loop strategy at -O2
- Authentication-results: sourceware.org; auth=none
- References: <CAFULd4YJFET7NOD_uuNVROW61PKbj5Y4nKN9rY=96+CRu3sMbg at mail dot gmail dot com>
Hi Uros,
You seems committing the test case in the wrong directory. I found it
in testsuite/gcc.target/pr66648.c.
Regards,
Renlin
On Sat, Jul 25, 2015 at 10:23 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
> We have to emit check for main loop execution UNLESS we guarantee that
> min_size is at least equal to size_needed. In this testcase, VRP
> declared minimum copying size, and after unaligned prologue
> adjustment, min_size was still non-zero. The !min_size check didn't
> account for the case that min_size can be non-zero, but still less
> than size_needed.
>
> 2015-07-25 Uros Bizjak <ubizjak@gmail.com>
>
> PR target/66648
> * config/i386/i386.c (ix86_expand_set_or_movmem): Emit main loop
> execution guard when min_size is less than size_needed.
>
> testsuite/ChangeLog:
>
> 2015-07-25 Uros Bizjak <ubizjak@gmail.com>
>
> PR target/66648
> * gcc.target/i386/pr66648.c: New test.
>
> Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.
>
> Committed to mainline, will be backported to release branches.
>
> Uros.