This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [AArch64] Remove unused VRL2/3/4 iterator values (was: Re: [PATCH 8/15][AArch64] Add support for float14x{4,8}_t vectors/builtins)
- From: James Greenhalgh <james dot greenhalgh at arm dot com>
- To: Alan Lawrence <Alan dot Lawrence at arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 30 Jul 2015 13:26:05 +0100
- Subject: Re: [AArch64] Remove unused VRL2/3/4 iterator values (was: Re: [PATCH 8/15][AArch64] Add support for float14x{4,8}_t vectors/builtins)
- Authentication-results: sourceware.org; auth=none
- References: <55B765DF dot 4040706 at arm dot com> <55B766B4 dot 2030305 at arm dot com> <20150729102409 dot GC5656 at arm dot com> <55BA0EC8 dot 60106 at arm dot com>
On Thu, Jul 30, 2015 at 12:47:20PM +0100, Alan Lawrence wrote:
> James Greenhalgh wrote:
> > On Tue, Jul 28, 2015 at 12:25:40PM +0100, Alan Lawrence wrote:
> >
> > I'd have preferred the unrelated changes here as separate patches. If you
> > pull them out, they are OK to commit independent of this patch.
>
> Done (r226352 and r226353).
>
> > Ah ok, I see what is going on here... None of these are actually used for
> > the 128-bit vector modes, so missing entries or incorrect entries for
> > V8HFmode don't matter.
>
> Hah, yes, you are right. Can I propose the attached patch as a first step, and
> then I'll repost what's left from my original plus the next patch (still
> currently fixing after rebasing over Charles' patches)...
>
> bootstrapped + check-gcc on aarch64-none-linux-gnu.
>
> gcc/ChangeLog:
>
> * config/aarch64/iterators.md (VRL2, VRL3, VRL4): Remove values for
> 128-bit vector modes.
>
> diff --git a/gcc/config/aarch64/iterators.md b/gcc/config/aarch64/iterators.md
> index b19d3d743a733303371341d9f323f47ed83618c3..37cb6938151ff8ce0b7e1bff18e575cf052c6a77 100644
> --- a/gcc/config/aarch64/iterators.md
> +++ b/gcc/config/aarch64/iterators.md
> @@ -540,24 +540,15 @@
>
> (define_mode_attr VRL2 [(V8QI "V32QI") (V4HI "V16HI")
> (V2SI "V8SI") (V2SF "V8SF")
> - (DI "V4DI") (DF "V4DF")
> - (V16QI "V32QI") (V8HI "V16HI")
> - (V4SI "V8SI") (V4SF "V8SF")
> - (V2DI "V4DI") (V2DF "V4DF")])
> + (DI "V4DI") (DF "V4DF")]
These all look to be missing a closing ')'.
Thanks,
James