This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function


On Sat, Jul 25, 2015 at 10:59:19AM -0500, Segher Boessenkool wrote:
> On Fri, Jul 24, 2015 at 10:37:00PM -0400, tbsaunde+gcc@tbsaunde.org wrote:
> > --- a/gcc/config/pa/pa.c
> > +++ b/gcc/config/pa/pa.c
> > @@ -9761,6 +9761,18 @@ pa_reloc_rw_mask (void)
> >    return 3;
> >  }
> >  
> > +/* Assemble a lable.  */
> 
> Typo.
> 
> > +void
> > +pa_output_label (FILE *f, const char *label)
> > +{
> > +  assemble_name (f, label);
> > +  if (TARGET_GAS)
> > +    fputs (":\n", f);
> > +  else
> > +    fputc ('\n', (f));
> 
> You forgot to remove the extra parens here :-)
> 
> If so many targets use default_assemble_label, can you make it an actual
> default instead of defining it everywhere?

 Well, it is the default, but many targets do over ride it to set it to
 the default ;)  Its certainly possible to remove some of those cases,
 but that seems like the sort of thing one might want to test more than
 just making sure gcc/ builds, and I'm not really set up to do that.  Is
 there a problem with leaving this for target maintainers to do?  It
 seems like an improvement over what we have, and I don't think they are
 getting in anyones way.

 Trev

> 
> 
> Segher


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]