Re: [PATCH] libierty: change _ANSIDECL_H to ANSIDECL_H

[Lawrence D'Anna <larry at elder-gods dot org>]

Iâm sorry, I misdiagnosed the problem, so you donât want to merge this patch.

What was really happening was that I had a different version of binutils installed in /usr/local/
and that had an ansidecl.h of its own, which was being used by the gcc build instead
of its own ansidecl.h

So there is a bug I think, because gcc ought to be using itâs own ansidecl.h,
but this patch is not the way to fix it. 

> On Jul 20, 2015, at 10:59 PM, Ian Lance Taylor <iant@google.com> wrote:
> 
> On Sun, Jul 19, 2015 at 9:22 PM, Lawrence D'Anna <larry@elder-gods.org> wrote:
>> 
>> ansidecl.h is using _ANSIDECL_H as it's guard #ifdef.  But names that start with
>> underscore are reserved, and the latest version of Xcode seems to be exercising
>> its prerogative to define _ANSIDECL_H.
>> 
>> This patch changes _ANSIDECL_H to ANSIDECL_H so Xcode can still be used to
>> bootstrap gcc.
> 
> Can you explain a bit more about how Xcode is using _ANSIDECL_H, and
> what problems it causes?
> 
> Otherwise it seems to me that there is a chance that changing the
> macro will simply cause the macro to pop up in some future version of
> Xcode.
> 
> Note that there are several other header files in the include
> directory that use reserved names.
> 
> Ian

Attachment: smime.p7s
Description: S/MIME cryptographic signature