This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][combine][1/2] Try to simplify before substituting


On Thu, Jul 16, 2015 at 07:17:54PM +0100, Kyrill Tkachov wrote:
> >If you always want to simplify first, does it work to move this whole big
> >block behind the simplify just following it?  Or do you want to simplify
> >after the transform as well?
> 
> You mean move this hunk outside the "if (BINARY_P (x)...)" block it's in?
> I think it would work, but I'm not sure if it would affect other cases.
> I was also conscious that simplify_rtx might not be a cheap function to call
> so frequently (or is it? I didn't profile it), so I tried to avoid calling
> it unless I need for the transformation in question here.

I mean move the whole "if (BINARY_P ..." block to after the existing
simplify calls, to just before the "First see if we can apply" comment,
and not do a new simplify_rtx call at all.  Does that work?

Which brings the question why it wasn't there in the first place, hrm.


Segher


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]