Re: PATCH trunk GCCJIT: adding gcc_jit_context_new_rvalue_from_long_long, etc...

[Basile Starynkevitch <basile at starynkevitch dot net>]

On 07/15/2015 20:52, David Malcolm wrote:
> On Wed, 2015-07-15 at 20:19 +0200, Basile Starynkevitch wrote:
> > Hello All and David Malcolm
> >
> > The attached patch (relative to trunk r224842) is adding
> > gcc_jit_context_new_rvalue_from_long_long and similar functions to
> > GCCJIT.

> * dump_to_reproducer support (most testcases attempt to dump their 
> contexts to a .c file and then sanity-check the generated c by 
> compiling them, though not running them; see jit.exp). A new API 
> entrypoint needs to "know" how to write itself back out to C (by 
> implementing gcc::jit::recording::memento::write_reproducer for the 
> appropriate memento subclass).


I'm sorry, but I can't understand the above comment. Where is the 
"Implementation of recording::memento::write_reproducer for longs." I 
can't find such comment in jit-recording.c!


BTW, it is really a pity that even a brand new subtree like gcc/jit/, 
coded mostly in C++, uses *.c
as the file extension for newly introduced C++ files. There is no legacy 
reason to use *.c extensions for new C++ files (as we had for source 
files of twenty years of age). I really find that confusing. And no 
comment mention that it is C++ not C!
It makes me almost cry :-)


Cheers.

--
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***