This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[gomp4] Revert "Work around nvptx offloading compiler --enable-checking=yes,df,fold,rtl breakage" (was: fix df verify failure)


Hi!

On Fri, 10 Jul 2015 18:04:36 -0400, Nathan Sidwell <nathan@acm.org> wrote:
> I've committed this patch to fix a df verify crash Thomas pointed me at. 

Thanks!

> Thomas, I think this means you can revert the workaround  you just committed?

Right.  Committed in r225714:

commit 687f194e535317024ca67c32b26bb277b6f266ae
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Sat Jul 11 19:21:48 2015 +0000

    Revert "Work around nvptx offloading compiler --enable-checking=yes,df,fold,rtl breakage"
    
    This reverts r225656; problem get addressed in r225695.
    
    	gcc/
    	* df-core.c (df_analyze_1): Don't disable df_verify call.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@225714 138bc75d-0d04-0410-961f-82ee72b054a4
---
 gcc/ChangeLog.gomp | 4 ++++
 gcc/df-core.c      | 2 --
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git gcc/ChangeLog.gomp gcc/ChangeLog.gomp
index baff20c..1f57a9d 100644
--- gcc/ChangeLog.gomp
+++ gcc/ChangeLog.gomp
@@ -1,3 +1,7 @@
+2015-07-11  Thomas Schwinge  <thomas@codesourcery.com>
+
+	* df-core.c (df_analyze_1): Don't disable df_verify call.
+
 2015-07-10  Nathan Sidwell  <nathan@codesourcery.com>
 
 	* config/nvptx/nvptx.c (nvptx_reorg): Move df problem setting, set
diff --git gcc/df-core.c gcc/df-core.c
index 52cca8e..67040a1 100644
--- gcc/df-core.c
+++ gcc/df-core.c
@@ -1235,12 +1235,10 @@ df_analyze_1 (void)
   if (dump_file)
     fprintf (dump_file, "df_analyze called\n");
 
-#if /* TODO */ 0
 #ifndef ENABLE_DF_CHECKING
   if (df->changeable_flags & DF_VERIFY_SCHEDULED)
 #endif
     df_verify ();
-#endif
 
   /* Skip over the DF_SCAN problem. */
   for (i = 1; i < df->num_problems_defined; i++)


GrÃÃe,
 Thomas

Attachment: pgp0otoOSJUxD.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]