This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] fixes -fcilkplus functionality on DragonFly (fixes ~2600 tests)
- From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: John Marino <gnugcc at marino dot st>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Andreas Tobler <andreast at gcc dot gnu dot org>
- Date: Sat, 11 Jul 2015 12:45:04 +0100
- Subject: Re: [patch] fixes -fcilkplus functionality on DragonFly (fixes ~2600 tests)
- Authentication-results: sourceware.org; auth=none
- References: <55A064A4 dot 5020302 at marino dot st> <55A0ADAC dot 1070007 at redhat dot com>
On 11 July 2015 at 06:46, Jeff Law wrote:
> On 07/10/2015 06:34 PM, John Marino wrote:
>>
>> After posting the first testsuite results for DragonFly, it was clear
>> that the -fcilkplus functionality was broken:
>> https://gcc.gnu.org/ml/gcc-testresults/2015-07/msg01046.html
>>
>> The problem was related to the __cpu_model symbol not getting exported.
>>
>> The solution was to create libgcc/config/i386/t-dragonfly to define an
>> additional symbol map (similar to t-freebsd). Simply creating the file
>> is enough because there's already a placeholder for t-dragonfly at
>> libgcc/config.host. The patch is attached.
>>
>> The improved results of the patch can be seen on the next posted
>> testsuite results:
>> https://gcc.gnu.org/ml/gcc-testresults/2015-07/msg01081.html
>>
>> An additional ~2600 tests now pass.
>> Please consider this patch for incorporation into trunk. Only DragonFly
>> uses the new t-dragonfly file so there is no impact to other platforms.
>>
>> suggested entry for libgcc/ChangeLog:
>>
>> 2015-07-XX John Marino <gnugcc@marino.st>
>>
>> * config/i386/t-dragonfly: New.
>
> OK.
> jeff
>
John, If you like I can commit this for you on Monday when I commit
your patch to os_defines.h.