This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Tests for libgomp based on OpenMP Examples 4.0.2.


On Thu, Jul 09, 2015 at 05:23:36PM +0300, Maxim Blumental wrote:
>  Now the patch is corrected (according to the previous letter) and
> ready to be reviewed. I'm looking forward to your feedback.

Ok, I guess while the filenames are still different, it is quite easily
possible to find corresponding test in the Examples git repo.

So, what remains is write proper ChangeLog entry, for all the renames and
other changes, like:
	* testsuite/libgomp.c/examples-4/e.55.1.c: Renamed to...
	* testsuite/libgomp.c/examples-4/async_target-1.c: ... this.
	* testsuite/libgomp.c/examples-4/e.55.2.c: Renamed to...
	* testsuite/libgomp.c/examples-4/async_target-2.c: ... this.
	(vec_mult_ref): Remove v1 and v2 arguments, turn them into
	local variables.
	(vec_mult): Likewise.  Add #pragma omp taskwait.
	(main): Adjust caller.
...
	* testsuite/libgomp.c/examples-4/simd-1.c: New file.
	* testsuite/libgomp.c/examples-4/simd-2.c: New file.
...
etc.  Also, in all dg-do run tests that use #pragma omp declare simd please
use { dg-do run { target vect_simd_clones } } instead of
{ dg-do run }, so that it does not fail miserably on darwin or other OSes
with less capable assemblers?

Have you reported that
!$omp for simd collapse(2) private(tmp)
->
!$omp simd collapse(2) private(tmp)
to omp-lang (or created ticket for it etc.)?

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]