This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Tests for libgomp based on OpenMP Examples 4.0.2.
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Maxim Blumental <bvmaks at gmail dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Kirill Yukhin <kirill dot yukhin at gmail dot com>
- Date: Thu, 9 Jul 2015 22:14:30 +0200
- Subject: Re: Tests for libgomp based on OpenMP Examples 4.0.2.
- Authentication-results: sourceware.org; auth=none
- References: <CACy_Q+xKW+w12_ChLX=iVPhM0PxHkQfasm=YRC+5tacpXKe6DQ at mail dot gmail dot com> <CACy_Q+yNNb4sBv6rvBawFNUt5LwbaOgjHHdRarfkhNqBULi1sw at mail dot gmail dot com> <20150707181748 dot GN10247 at tucnak dot redhat dot com> <20150707182957 dot GA65276 at msticlxl57 dot ims dot intel dot com> <CACy_Q+y63uv+SpyAXfCE6a+zN3otCQCjCK-FTwbn=4PORmoyhg at mail dot gmail dot com> <CACy_Q+y96DX3C062vXhdQhFexXr-p8FgwAD58+WOM93NLk98Gg at mail dot gmail dot com> <CACy_Q+yaHA==aD_S9NEb-hQZ=DamC+GgjorcT5vE0j3nhVcDdQ at mail dot gmail dot com> <CACy_Q+z+oKdypFsPstzERG8MpK6Oc97o-A8=X8eh6soWK6fPuQ at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Jul 09, 2015 at 05:23:36PM +0300, Maxim Blumental wrote:
> Now the patch is corrected (according to the previous letter) and
> ready to be reviewed. I'm looking forward to your feedback.
Ok, I guess while the filenames are still different, it is quite easily
possible to find corresponding test in the Examples git repo.
So, what remains is write proper ChangeLog entry, for all the renames and
other changes, like:
* testsuite/libgomp.c/examples-4/e.55.1.c: Renamed to...
* testsuite/libgomp.c/examples-4/async_target-1.c: ... this.
* testsuite/libgomp.c/examples-4/e.55.2.c: Renamed to...
* testsuite/libgomp.c/examples-4/async_target-2.c: ... this.
(vec_mult_ref): Remove v1 and v2 arguments, turn them into
local variables.
(vec_mult): Likewise. Add #pragma omp taskwait.
(main): Adjust caller.
...
* testsuite/libgomp.c/examples-4/simd-1.c: New file.
* testsuite/libgomp.c/examples-4/simd-2.c: New file.
...
etc. Also, in all dg-do run tests that use #pragma omp declare simd please
use { dg-do run { target vect_simd_clones } } instead of
{ dg-do run }, so that it does not fail miserably on darwin or other OSes
with less capable assemblers?
Have you reported that
!$omp for simd collapse(2) private(tmp)
->
!$omp simd collapse(2) private(tmp)
to omp-lang (or created ticket for it etc.)?
Jakub