This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Remove duplicate graphite statistics printers
- From: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>
- To: Jeff Law <law at redhat dot com>,gcc-patches at gcc dot gnu dot org
- Cc: Daniel Berlin <dberlin at dberlin dot org>,Tobias Grosser <grosser at fim dot uni-passau dot de>,Sebastian Pop <sebpop at gmail dot com>
- Date: Thu, 09 Jul 2015 19:48:30 +0200
- Subject: Re: [PATCH] Remove duplicate graphite statistics printers
- Authentication-results: sourceware.org; auth=none
- References: <1436459431-14567-1-git-send-email-rep dot dot dot nop at gmail dot com> <559EA5E7 dot 2070402 at redhat dot com>
On July 9, 2015 6:48:39 PM GMT+02:00, Jeff Law <law@redhat.com> wrote:
>On 07/09/2015 10:30 AM, Bernhard Reutner-Fischer wrote:
>>
>> Thanks,
>>
>> gcc/ChangeLog
>>
>> 2015-07-09 Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
>>
>> * graphite.h: New file.
>> (print_graphite_statistics): Extern declaration.
>> * graphite-scop-detection.c (print_graphite_scop_statistics,
>> print_graphite_statistics): Remove.
>> * graphite.c (print_graphite_statistics): Make public and add
>> PREFIX parameter. Adjust callers.
>> (print_graphite_scop_statistics): Add PREFIX parameter.
>>
>> Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
>> ---
>> -/* Print statistics for SCOPS to FILE. */
>> +/* Print statistics for SCOPS to FILE. Prefix statistic headers with
>PREFIX. */
>Nit. Two spaces after a period, even in comments.
Done.
I wasn't sure where to put the prototype, maybe a graphite.h for just that (ATM) is not warranted?
Maybe an extern decl in graphite-scop-detection.c would be sufficient?
>
>
>With that nit fixed, OK for the trunk after a bootstrap and regression
>test.
Thanks,
>
>jeff