Re: [PATCH, libiberty]: Avoid "enum conversion when passing argument 1 of âgetrusageâ is invalid in C++" warning

[Uros Bizjak <ubizjak at gmail dot com>]

On Thu, Jul 9, 2015 at 3:00 PM, Ian Lance Taylor <iant@golang.org> wrote:
> On Wed, Jul 1, 2015 at 3:07 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
>>
>> This patch avoids "enum conversion when passing argument 1 of
>> âgetrusageâ is invalid in C++" warning when compiling getruntime.c.
>> The condition is copied from sys/resource.h.
>
> Sorry, I've been on vacation.
>
> I think it would be a lot nicer to always use RUSAGE_SELF in the
> function, and earlier in the file write
>
> #ifndef RUSAGE_SELF
> #define RUSAGE_SELF 0
> #endif

Indeed, attached patch builds without warning.

2015-07-09  Uros Bizjak  <ubizjak@gmail.com>

    * getruntime.c (RUSAGE_SELF): Define if not already defined.
    (get_runtime): Use RUSAGE_SELF as argument 1 of getrusage call.

Bootstrapped on x86_64-linux-gnu.

OK for mainline SVN?

Uros.

Attachment: l.diff.txt
Description: Text document