This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCH] MIPS: fix failing branch range checks for micromips
- From: "Moore, Catherine" <Catherine_Moore at mentor dot com>
- To: Andrew Bennett <Andrew dot Bennett at imgtec dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- Date: Wed, 8 Jul 2015 16:11:51 +0000
- Subject: RE: [PATCH] MIPS: fix failing branch range checks for micromips
- Authentication-results: sourceware.org; auth=none
- References: <0DA23CC379F5F945ACB41CF394B98277210EDC9C at LEMAIL01 dot le dot imgtec dot org> <FD3DCEAC5B03E9408544A1E416F112420192C3C173 at NA-MBX-01 dot mgc dot mentorg dot com> <0DA23CC379F5F945ACB41CF394B98277210F0037 at LEMAIL01 dot le dot imgtec dot org> <FD3DCEAC5B03E9408544A1E416F112420192C3C624 at NA-MBX-01 dot mgc dot mentorg dot com> <0DA23CC379F5F945ACB41CF394B98277210F0D2C at LEMAIL01 dot le dot imgtec dot org>
> -----Original Message-----
> From: Andrew Bennett [mailto:Andrew.Bennett@imgtec.com]
> Sent: Wednesday, July 08, 2015 11:17 AM
> To: Moore, Catherine; gcc-patches@gcc.gnu.org
> Cc: Matthew Fortune
> Subject: RE: [PATCH] MIPS: fix failing branch range checks for micromips
>
> > > testsuite/
> > > * gcc.target/mips/branch-2.c: Change NOMIPS16 to
> NOCOMPRESSION.
> > > * gcc.target/mips/branch-3.c: Ditto
> > > * gcc.target/mips/branch-4.c: Ditto.
> > > * gcc.target/mips/branch-5.c: Ditto.
> > > * gcc.target/mips/branch-6.c: Ditto.
> > > * gcc.target/mips/branch-7.c: Ditto.
> > > * gcc.target/mips/branch-8.c: Ditto.
> > > * gcc.target/mips/branch-9.c: Ditto.
> > > * gcc.target/mips/branch-10.c: Ditto.
> > > * gcc.target/mips/branch-11.c: Ditto.
> > > * gcc.target/mips/branch-12.c: Ditto.
> > > * gcc.target/mips/branch-13.c: Ditto.
> >
> > These are OK, except for the splitting of the scan-assembler statements.
> >
> > Please change occurrences of:
> > > +/* { dg-final { scan-assembler
> > > +"\tld\t\\\$1,%got_page\\(\[^)\]*\\)\\(\\\$3\\)\\n" } } */
> > to:
> > +/* { dg-final { scan-assembler
> > "\tld\t\\\$1,%got_page\\(\[^)\]*\\)\\(\\\$3\\)\\n" } } */
> >
> > before committing.
>
> I think this might be a problem with your email client, as these issues do not
> occur in my patch submission.
>
Yes, it would appear that way. Sorry for the noise.
>
>
> > > * gcc.target/mips/branch-14.c: Ditto.
> > > * gcc.target/mips/branch-15.c: Ditto.
> >
> > The modifications for these two files need to be removed. These are
> > execution tests and the multilib that is used to link them is important. If
> > the libraries are not compatible with the NOCOMPRESSION attribute,
> > then the link step will fail. You could work around this problem by
> > enabling interlinking, but I think the best approach is to leave these two
> tests alone.
>
> Firstly, I have committed a patch which does not include the branch-[14,15].c
> and umips-branch-[17,18].c changes (SVN 225540). However, I am keen to
> get these changes committed purely so that we have an in-range micromips
> branch execution test (which none of the current tests provide). I need to
> look at the mips.exp file in more detail, but I was wondering if you would be
> happy to keep these tests in, but downgrade them to assemble tests if the
> required multilib support does not exist?
>
How about adding the interlinking option to the umips-branch-[17,18].c tests instead?
Ie. /* { dg-options "(-mmicromips) -minterlink-compressed" } */