This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING 3] Re: [PATCH] warn for unsafe calls to __builtin_return_address
- From: Pedro Alves <alves dot ped at gmail dot com>
- To: Martin Sebor <msebor at gmail dot com>, Gcc Patch List <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 07 Jul 2015 11:14:20 +0100
- Subject: Re: [PING 3] Re: [PATCH] warn for unsafe calls to __builtin_return_address
- Authentication-results: sourceware.org; auth=none
- References: <555E2FC6 dot 60804 at redhat dot com> <555E50A5 dot 60309 at redhat dot com> <557A0617 dot 6040605 at redhat dot com> <5582FCAC dot 2070209 at redhat dot com> <558DE4F9 dot 3070301 at gmail dot com> <559B4A67 dot 6070201 at gmail dot com>
On 07/07/2015 04:41 AM, Martin Sebor wrote:
> This is a small change to diagnose unsafe calls to
> __builtin_{frame,return}_address (with an argument > 2) than
> tend to return bogus values or lead to crashes at runtime.
>
I hadn't realized you went through and implemented the
suggestion. Thanks for doing this. I hope it gets approved.
> A review would be appreciated.
(It may be the relevant maintainers haven't noticed there's a
code patch here because this is nested within
the "[PATCH] clarify doc for __builtin_return_address" thread).)
Thanks,
Pedro Alves