This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [Patch,microblaze]: Optimized usage of reserved stack space for function arguments.
- From: Ajit Kumar Agarwal <ajit dot kumar dot agarwal at xilinx dot com>
- To: Oleg Endo <oleg dot endo at t-online dot de>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Vinod Kathail <vinodk at xilinx dot com>, Shail Aditya Gupta <shailadi at xilinx dot com>, Vidhumouli Hunsigida <vidhum at xilinx dot com>, Nagaraju Mekala <nmekala at xilinx dot com>
- Date: Tue, 7 Jul 2015 03:12:18 +0000
- Subject: RE: [Patch,microblaze]: Optimized usage of reserved stack space for function arguments.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; gcc.gnu.org; dkim=none (message not signed) header.d=none;
- References: <37378DC5BCD0EE48BA4B082E0B55DFAA41F41AB7 at XAP-PVEXMBX02 dot xlnx dot xilinx dot com> <85BC443E-73C7-4385-9819-67DD4736FFDA at t-online dot de>
-----Original Message-----
From: Oleg Endo [mailto:oleg.endo@t-online.de]
Sent: Monday, July 06, 2015 7:07 PM
To: Ajit Kumar Agarwal
Cc: GCC Patches; Vinod Kathail; Shail Aditya Gupta; Vidhumouli Hunsigida; Nagaraju Mekala
Subject: Re: [Patch,microblaze]: Optimized usage of reserved stack space for function arguments.
>>Hi,
>>Just some general comments...
Thanks.
On 06 Jul 2015, at 22:05, Ajit Kumar Agarwal <ajit.kumar.agarwal@xilinx.com> wrote:
> +static bool
> +microblaze_parm_needs_stack (cumulative_args_t args_so_far, tree
> +type) {
> + enum machine_mode mode;
^^^^
>> 'enum' is not required in C++, please omit it.
>> We've been trying to remove unnecessary 'struct' and 'enum' after the
>>switch to C++. Although there are still some of them around, please
>>don't add new ones.
Sure.
> + int unsignedp;
> + rtx entry_parm;
^^^^
>>Please declare variables at their first use.
>>(there are other such cases in your patch)
I have declared the above variables in the first scope of their first use. Sorry, it's not clear to me.
You meant to say to declare in the following way.
int unsignedp = TYPE_UNSIGNED (type);
rtx entry_parm = microblaze_function_arg (args_so_far, mode, type, true);
Thanks & Regards
Ajit
Cheers,
Oleg