Re: [PATCH 4/7] Fix int overflow

[Jeff Law <law at redhat dot com>]

On 07/06/2015 01:36 PM, Mikhail Maltsev wrote:
> ---
>   libiberty/cp-demangle.c               | 3 ++-
>   libiberty/testsuite/demangle-expected | 4 ++++
>   2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c
> index 44a0a9b..befa6b6 100644
> --- a/libiberty/cp-demangle.c
> +++ b/libiberty/cp-demangle.c
> @@ -103,6 +103,7 @@
>   #include "config.h"
>   #endif
>
> +#include <limits.h>
>   #include <stdio.h>
>
>   #ifdef HAVE_STDLIB_H
> @@ -1599,7 +1600,7 @@ d_source_name (struct d_info *di)
>     struct demangle_component *ret;
>
>     len = d_number (di);
> -  if (len <= 0)
> +  if (len <= 0 || len > INT_MAX)
>       return NULL;
>     ret = d_identifier (di, len);
>     di->last_name = ret;
Isn't this only helpful if sizeof (long) > sizeof (int)?  Otherwise the 
compiler is going to eliminate that newly added test, right?

So with that in mind, what happens on i686-unknown-linux with this test?


Jeff