This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation

From: Jeff Law <law at redhat dot com>
To: Ajit Kumar Agarwal <ajit dot kumar dot agarwal at xilinx dot com>, Joseph Myers <joseph at codesourcery dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Vinod Kathail <vinodk at xilinx dot com>, Shail Aditya Gupta <shailadi at xilinx dot com>, Vidhumouli Hunsigida <vidhum at xilinx dot com>, Nagaraju Mekala <nmekala at xilinx dot com>
Date: Mon, 06 Jul 2015 14:08:48 -0600
Subject: Re: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation
Authentication-results: sourceware.org; auth=none
References: <37378DC5BCD0EE48BA4B082E0B55DFAA41F3F56C at XAP-PVEXMBX02 dot xlnx dot xilinx dot com> <alpine dot DEB dot 2 dot 10 dot 1506302216120 dot 16184 at digraph dot polyomino dot org dot uk> <37378DC5BCD0EE48BA4B082E0B55DFAA41F403C4 at XAP-PVEXMBX02 dot xlnx dot xilinx dot com>

On 07/01/2015 09:51 PM, Ajit Kumar Agarwal wrote:



-----Original Message-----
From: Joseph Myers [mailto:joseph@codesourcery.com]
Sent: Wednesday, July 01, 2015 3:48 AM
To: Ajit Kumar Agarwal
Cc: law@redhat.com; GCC Patches; Vinod Kathail; Shail Aditya Gupta; Vidhumouli Hunsigida; Nagaraju Mekala
Subject: Re: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation

On Tue, 30 Jun 2015, Ajit Kumar Agarwal wrote:

         * gcc/common.opt: Add the new flag ftree-path-split.

All options need documenting in invoke.texi.


Sure.

+#include "tm.h"

Why?  Does some other header depend on this, or are you using a target macro?


I am not using any target macro. There are many header files that includes the tm.h and also there are many tree-ssa optimization
files that have included  "tm.h"  listing some of them tree-ssa-threadupdate.c  tree-vrp.c ,  tree-ssa-threadedge.c.

But the question is do you actually need "tm.h" -- we're in the middleof a project to better separate the front ends from the gimpleoptimizers from the RTL optimizers & backends.

Including "tm.h" in places where it's not really needed makes achievingand maintaining the separation harder than it should be.

In general we should only be including the header files that areactually needed.


Jeff

References:
- RE: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation
  - From: Ajit Kumar Agarwal

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]