This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCH] Fix mips-{mti,img}-linux-gnu boot-strap
- From: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- To: Bernd Edlinger <bernd dot edlinger at hotmail dot de>, Richard Sandiford <rdsandiford at googlemail dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Catherine Moore <clm at codesourcery dot com>
- Date: Sat, 4 Jul 2015 16:59:12 +0000
- Subject: RE: [PATCH] Fix mips-{mti,img}-linux-gnu boot-strap
- Authentication-results: sourceware.org; auth=none
- References: <DUB118-W47AD7C2761ED5C2CF803E6E4950 at phx dot gbl>,<87fv54uz52 dot fsf at googlemail dot com> <DUB118-W3494A9FC7ADC61BEB7E01E4950 at phx dot gbl>
Bernd Edlinger <bernd.edlinger@hotmail.de> writes:
> On Sat, 4 Jul 2015 09:04:41, Richard Sandiford wrote:
> >
> > The final return here would also mishandle SEQUENCE PATTERNs.
> > The idea was that this function would only see "real" instructions,
> > so I think instead the FOR_EACH_SUBINSN should be here:
> >
> > static bool
> > mips_find_gp_ref (bool *cache, bool (*pred) (rtx_insn *))
> > {
> > rtx_insn *insn;
> >
> > if (!*cache)
> > {
> > push_topmost_sequence ();
> > for (insn = get_insns (); insn; insn = NEXT_INSN (insn))
> > ---->
> > if (USEFUL_INSN_P (insn) && pred (insn))
> >
> > Thanks,
> > Richard
>
> Yes, I agree.
>
> I have now updated my patch as suggested.
>
> A mips-img-linux-gnu cross compiler builds as expected.
>
> OK for trunk?
OK, thanks.
Matthew