This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Fortran f951, C++14] Fix trans-common.c compilation failure on AIX
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: David Edelsohn <dje dot gcc at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Fortran List <fortran at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>, Tobias Burnus <burnus at net-b dot de>
- Date: Fri, 3 Jul 2015 10:32:38 +0200
- Subject: Re: [Fortran f951, C++14] Fix trans-common.c compilation failure on AIX
- Authentication-results: sourceware.org; auth=none
- References: <CAGWvnymPserBXTuFV57kktm8icVnnx2B1Zo7V0jGhJ8_6dfRBw at mail dot gmail dot com> <20150702203208 dot GI10247 at tucnak dot redhat dot com> <CAGWvny=CbddUR79AMNwpVCXz7OqNjQvPvkPp61gebxiYmXbfWA at mail dot gmail dot com> <20150702204933 dot GJ10247 at tucnak dot redhat dot com>
On Thu, Jul 2, 2015 at 10:49 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Thu, Jul 02, 2015 at 04:47:13PM -0400, David Edelsohn wrote:
>> I can change the patch to include it after system.h, if that is
>> preferred. That order also works on AIX.
>
> If including it right after system.h works, it is preapproved.
Note that after config.h is generally better (considering all the #poison
stuff in system.h).
Not using std::map but GCCs own hash_map would be prefered though.
(otherwise at some point we'll end up including all of libstdc++ from
system.h given host compiler weirdness and workarounds for include
stuff - which is what system.h is for)
Richard.
> Jakub